Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure LoadBalancer module : remove wrong Expand Query param #1093

Merged
merged 1 commit into from Apr 12, 2022

Conversation

HadwaAbdelhalem
Copy link
Contributor

@HadwaAbdelhalem HadwaAbdelhalem commented Mar 29, 2022

Fixes #1091

Link to PR code branch CI. The failures are mostly due to quote limits on my subscription and AzureLoadBalancer related tests passed

@HadwaAbdelhalem
Copy link
Contributor Author

@HadwaAbdelhalem HadwaAbdelhalem commented Mar 29, 2022

Hi @yorinasub17, PR is ready for review when you get a chance

@HadwaAbdelhalem HadwaAbdelhalem changed the title remove wrong Expand Query param Azure LoadBalancer module : remove wrong Expand Query param Mar 29, 2022
@yorinasub17
Copy link
Member

@yorinasub17 yorinasub17 commented Apr 12, 2022

LGTM! We had a build failure on our build (now fixed in master), but since this is Azure related, your build has more authority so will go ahead and merge this in.

@yorinasub17 yorinasub17 merged commit 2bac268 into gruntwork-io:master Apr 12, 2022
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants