Adding suport for -var-file and -target argument #201

aclowkey · 2018-11-29T12:09:18Z

brikis98

This looks great, thanks! Could you add some sort of test for this? E.g., deploy one of the existing examples by creating and pass some required params via a var file?

aclowkey · 2018-11-29T12:20:18Z

Any tips on how to make it simple as possible?

aclowkey · 2018-11-29T14:56:58Z

What do you think ? I didn't test yet, but Ill do as soon as I can.

brikis98

The test looks perfect, thanks! Let me know once you've run it and confirmed it works, and this is ready to merge.

modules/terraform/cmd.go

test/terraform_basic_example_test.go

aclowkey · 2018-12-01T13:38:58Z

I'm struggling with running the tests :S

For some reason go isn't aware of the change in the files..

ac@ac-PC:~/go/src/github.com/gruntwork-io/terratest/test$ go test -v -run TestTerraformBasicExample
# github.com/gruntwork-io/terratest/test
./terraform_basic_example_test.go:25:11: unknown field 'VarFiles' in struct literal of type terraform.Options
FAIL	github.com/gruntwork-io/terratest/test [build failed]

brikis98 · 2018-12-02T14:00:06Z

That's weird. Did you set up your GOPATH correctly?

The working directory is TerraformDir, so full path isn't necessary

aclowkey · 2018-12-02T15:27:17Z

I tried on a different machine and it worked!. I think it's because I had a symbolic link to a different directory.. I guess go doesn't like that.

Now the test pass, I need to add a test for -target now

The local_file has both data so the output would have both of them too

brikis98 · 2018-12-03T14:58:19Z

Are all the tests added and passing now?

aclowkey · 2018-12-03T15:03:30Z

Yes

…

On Mon, 3 Dec 2018 at 16:58, Yevgeniy Brikman ***@***.***> wrote: Are all the tests added and passing now? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#201 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB9y2Y-2_ANKAfiIUyM6HzudpH_pqGM2ks5u1TwOgaJpZM4Y5iqv> .

brikis98

OK, this is just about ready to merge. Just a couple last minor items. Thanks!

brikis98 · 2018-12-03T15:15:27Z

modules/terraform/format.go

+// FormatTerraformArgs will format multiple args with the arg name (e.g. arg-file a arg-file b)
+func FormatTerraformArgs(argName string, args []string) []string {
+	argsList := []string{}
+	for _, varFile := range args {


argValue is probably a better name here than varFile

brikis98 · 2018-12-03T15:16:39Z

modules/terraform/format.go

@@ -19,6 +23,15 @@ func FormatTerraformVarsAsArgs(vars map[string]interface{}) []string {
 	return formatTerraformArgs(vars, "-var")
 }

+// FormatTerraformArgs will format multiple args with the arg name (e.g. arg-file a arg-file b)


A more realistic example might help explain what this method does. E.g.,

FormatTerraformArgs("-var-file", []string{"foo.tfvars", "bar.tfvars"}) returns "-var-file foo.tfvars -var-file bar.tfvars"

brikis98 · 2018-12-03T15:18:16Z

test/terraform_basic_example_test.go

+		Targets: []string{"local_file.example"},
+
+		// Use the var files
+		VarFiles: []string{"varfile.tfvars"},


Hm, terraform_basic_example_test.go should be, well, a basic example intended to provide simple example code for Terratest newbies. I think Targets and VarFiles and the corresponding checks may be a little too complex for someone just starting out. Perhaps move this example + corresponding test code to a different example?

brikis98 · 2019-01-17T13:20:56Z

@aclowkey What is the latest status with this. Have all comments been resolved?

aclowkey · 2019-01-17T13:27:59Z

No. The only unresolved issue is that of having it in another example. I will comment about it
EDIT: Ok. So I will create a similar example, just with var-files and target, and leave the example to be basic

kurtmaile · 2019-02-16T17:52:39Z

Will this be merged soon by any chance?

brikis98 · 2019-02-17T12:11:04Z

@aclowkey Did you add all tests/examples you were planning to?

aclowkey · 2019-02-17T12:12:37Z

Yes

…

On Sun, 17 Feb 2019 at 14:11, Yevgeniy Brikman ***@***.***> wrote: @aclowkey <https://github.com/aclowkey> Did you add all tests/examples you were planning to? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#201 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB9y2Q801HuS02DaKjj_uHkdLllf8P5wks5vOUbbgaJpZM4Y5iqv> .

brikis98

Great, thanks! I'll merge this now and let the tests run. If they pass, I'll issue a new release.

brikis98 · 2019-02-17T15:34:47Z

https://github.com/gruntwork-io/terratest/releases/tag/v0.13.27

Adding suport for -var-file argument

d87d64c

brikis98 reviewed Nov 29, 2018

View reviewed changes

Adding suppor for -target argument

77a9c6f

aclowkey changed the title ~~Adding suport for -var-file argument~~ Adding suport for -var-file and -target argument Nov 29, 2018

aclowkey added 3 commits November 29, 2018 14:31

Fix to wrong variable

eb1cff5

Adding -var-file to the basic test

f23bba5

Typo

ca8850b

brikis98 reviewed Nov 30, 2018

View reviewed changes

modules/terraform/cmd.go Outdated Show resolved Hide resolved

test/terraform_basic_example_test.go Outdated Show resolved Hide resolved

Fixing syntax, path of varfile and todo

8773566

aclowkey added 2 commits December 1, 2018 15:41

Should be example2

24ed719

Fixing test expectations

05c4504

aclowkey added 3 commits December 2, 2018 17:02

Fix to incorrect variable

cd72963

-var-file isn't a common options, so add where applicable

0fdb08e

FIX the path

596eee2

The working directory is TerraformDir, so full path isn't necessary

aclowkey added 3 commits December 3, 2018 12:28

REFACTOR: Pass entire options struct instead of individual fields of it

ca64097

Should add the args as well

efd4f31

Adding test for the -target parameter

d9690bb

The local_file has both data so the output would have both of them too

brikis98 reviewed Dec 3, 2018

View reviewed changes

aclowkey added 3 commits December 4, 2018 08:19

Documentation, renaming variable

2c5fdd4

Simplifying to test. Making sure both local_file were created

e4ebcc0

Fix to broken comment

5e44bf0

brikis98 mentioned this pull request Jan 17, 2019

-Var-File Support #192

Closed

Moving VarFiles to a different example

943ed7f

brikis98 approved these changes Feb 17, 2019

View reviewed changes

brikis98 merged commit 5c24de4 into gruntwork-io:master Feb 17, 2019

brikis98 mentioned this pull request Feb 17, 2019

Fix test failure in TestTerraformBasicExample #238

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding suport for -var-file and -target argument #201

Adding suport for -var-file and -target argument #201

aclowkey commented Nov 29, 2018 •

edited

brikis98 left a comment

aclowkey commented Nov 29, 2018

aclowkey commented Nov 29, 2018

brikis98 left a comment

aclowkey commented Dec 1, 2018

brikis98 commented Dec 2, 2018

aclowkey commented Dec 2, 2018

brikis98 commented Dec 3, 2018

aclowkey commented Dec 3, 2018 via email

brikis98 left a comment

brikis98 Dec 3, 2018

brikis98 Dec 3, 2018

brikis98 Dec 3, 2018

brikis98 commented Jan 17, 2019

aclowkey commented Jan 17, 2019 •

edited

kurtmaile commented Feb 16, 2019

brikis98 commented Feb 17, 2019

aclowkey commented Feb 17, 2019 via email

brikis98 left a comment

brikis98 commented Feb 17, 2019

Adding suport for -var-file and -target argument #201

Adding suport for -var-file and -target argument #201

Conversation

aclowkey commented Nov 29, 2018 • edited

brikis98 left a comment

Choose a reason for hiding this comment

aclowkey commented Nov 29, 2018

aclowkey commented Nov 29, 2018

brikis98 left a comment

Choose a reason for hiding this comment

aclowkey commented Dec 1, 2018

brikis98 commented Dec 2, 2018

aclowkey commented Dec 2, 2018

brikis98 commented Dec 3, 2018

aclowkey commented Dec 3, 2018 via email

brikis98 left a comment

Choose a reason for hiding this comment

brikis98 Dec 3, 2018

Choose a reason for hiding this comment

brikis98 Dec 3, 2018

Choose a reason for hiding this comment

brikis98 Dec 3, 2018

Choose a reason for hiding this comment

brikis98 commented Jan 17, 2019

aclowkey commented Jan 17, 2019 • edited

kurtmaile commented Feb 16, 2019

brikis98 commented Feb 17, 2019

aclowkey commented Feb 17, 2019 via email

brikis98 left a comment

Choose a reason for hiding this comment

brikis98 commented Feb 17, 2019

aclowkey commented Nov 29, 2018 •

edited

aclowkey commented Jan 17, 2019 •

edited