Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when mafft is not installed. #7

Closed
knausb opened this issue Aug 16, 2017 · 2 comments
Closed

Tests fail when mafft is not installed. #7

knausb opened this issue Aug 16, 2017 · 2 comments

Comments

@knausb
Copy link

knausb commented Aug 16, 2017

When running tests I receive:

Error: MAFFT not found in the specified path: '//mafft'
 Please check your MAFFT installation.
In addition: Warning messages:
1: running command 'which mafft' had status 1 
2: running command 'which hmmsearch' had status 1 
Execution halted

Exited with status 1.

This is reproduced as follows.

source('~/gits/effectR/tests/testthat/test_effector_summary.R')

Which dumps me into the browser on my system. Here I see:

Browse[1]> mafft.path
[1] "/"

which may be an unanticipated value?

@zachary-foster
Copy link
Contributor

This is due to this line:

mafft.path <- paste0(dirname(system("which mafft", intern = T)), "/")

dirname(system("which mafft", intern = T)) is returning nothing, which is then appended to "/" and passed to get_mafft_path, which interprets it as a user-defined path to a directory and adds "mafft" to it.

@Tabima Tabima closed this as completed in dbc47aa Aug 16, 2017
@Tabima
Copy link
Member

Tabima commented Aug 16, 2017

@knausb Can you test again? The new commit should address that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants