From f725a85011fc9342d37f55c58ba35926a94b6d0a Mon Sep 17 00:00:00 2001 From: Gregor Santner Date: Tue, 8 Sep 2020 15:11:51 +0200 Subject: [PATCH] Improve todo.txt done/date hl color for dark mode, by @gsantner closes #1038 --- .../markor/format/todotxt/TodoTxtHighlighter.java | 6 ++++-- .../markor/format/todotxt/TodoTxtHighlighterColors.java | 8 ++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtHighlighter.java b/app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtHighlighter.java index 47d97dace32..7e26542f1ae 100644 --- a/app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtHighlighter.java +++ b/app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtHighlighter.java @@ -38,6 +38,8 @@ protected Editable run(final Editable editable) { return editable; } + final boolean isDarkBg = _appSettings.isDarkThemeEnabled(); + _profiler.start(true, "Todo.Txt Highlighting"); generalHighlightRun(editable); _profiler.restart("Paragraph top padding"); @@ -70,7 +72,7 @@ protected Editable run(final Editable editable) { // Date: Match Creation date before completition date _profiler.restart("Date Color"); - createColorSpanForMatches(editable, TodoTxtHighlighterPattern.DATE.getPattern(), colors.getDateColor()); + createColorSpanForMatches(editable, TodoTxtHighlighterPattern.DATE.getPattern(), colors.getDateColor(isDarkBg)); createColorSpanForMatches(editable, TodoTxtHighlighterPattern.DUE_DATE.getPattern(), colors.getPriorityColor(1), 1); //createColorSpanForMatches(editable, TodoTxtHighlighterPattern.CREATION_DATE.getPattern(), 0xff00ff00); //createColorSpanForMatches(editable, TodoTxtHighlighterPattern.COMPLETION_DATE.getPattern(), 0xff0000ff); @@ -83,7 +85,7 @@ protected Editable run(final Editable editable) { // Strike out done tasks (apply no other to-do.txt span format afterwards) _profiler.restart("Done BgColor"); - createColorSpanForMatches(editable, TodoTxtHighlighterPattern.DONE.getPattern(), colors.getDoneColor()); + createColorSpanForMatches(editable, TodoTxtHighlighterPattern.DONE.getPattern(), colors.getDoneColor(isDarkBg)); _profiler.restart("done Strike"); createSpanWithStrikeThroughForMatches(editable, TodoTxtHighlighterPattern.DONE.getPattern()); diff --git a/app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtHighlighterColors.java b/app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtHighlighterColors.java index f8152cbaef0..d5fa9b459c6 100644 --- a/app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtHighlighterColors.java +++ b/app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtHighlighterColors.java @@ -43,12 +43,12 @@ public int getPriorityColor(int priority) { } } - public int getDoneColor() { - return 0x993d3d3d; + public int getDoneColor(boolean isDarkBg) { + return isDarkBg ? 0x999d9d9d :0x993d3d3d; } - public int getDateColor() { - return 0xcc6d6d6d; + public int getDateColor(boolean isDarkBg) { + return isDarkBg ? getDoneColor(isDarkBg) : 0xcc6d6d6d; } public int getCategoryColor() {