Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy feature: Disallow screenshots (Secure flag) #1174

Closed
gsantner opened this issue Dec 28, 2020 · 13 comments · Fixed by #1514
Closed

Privacy feature: Disallow screenshots (Secure flag) #1174

gsantner opened this issue Dec 28, 2020 · 13 comments · Fixed by #1514

Comments

@gsantner
Copy link
Owner

General information

  • App version: 2.5
  • System: Android 11

Description

  • The goal is to add feature to app to disallow screenshots of the running Markor app (so other apps cannot screenshot or see what you write).
  • Should be a settings option to enable/disable globally for all activities in the Markor app
  • Make it enabled by default
  • Optionally, if you find some other security/privacy improvements&tweaks, can also be added (comment if you have something)

Check documentation for FLAG_SECURE and related Android Developers security/privacy guides.
Overall it should be quite easy to implement this, settings are more or less copy paste from existing checkboxes 😉 .

@Ln11211
Copy link

Ln11211 commented Oct 2, 2021

@gsantner, As it reads good first issue and you said it's more or less copy paste, canI try this ?

@gsantner

This comment has been minimized.

@Ln11211
Copy link

Ln11211 commented Oct 5, 2021

@gsantner , I found a nice resource and it says that you can use a built in mechanism to prevent screenshots. Check out the link and let me know if we can use this to implement it.

I also found one in stackoverflow that prevents taking screenshot when an app goes to background..

But, this one from geeksforgeeks seems good and simple, geeksforgeeks .

I would like to go with the code by geeksforgeeks...

@gsantner
Copy link
Owner Author

gsantner commented Oct 5, 2021

yes java FLAG_SECURE is what you need.

@Ln11211 Ln11211 removed their assignment Oct 6, 2021
@Ln11211

This comment has been minimized.

@gsantner

This comment has been minimized.

@unnikrishnan2002

This comment has been minimized.

@gsantner

This comment has been minimized.

@Ln11211

This comment has been minimized.

@gsantner

This comment has been minimized.

@simonesummo
Copy link
Contributor

@unnikrishnan2002 any update on this? Otherwise I will dig into it.

@gsantner
Copy link
Owner Author

@Zoo-M0
It happens every year in october (/hacktoberfest) that many people want to start on many things, but mostly nothing happens.
Unless there is merge request open, generally consider all issues/bugs/features open. Currently there are 0 open ... so everything 😄 .

@simonesummo
Copy link
Contributor

@gsantner perfect, I will look into it

simonesummo pushed a commit to simonesummo/markor that referenced this issue Dec 9, 2021
@gsantner gsantner linked a pull request Dec 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants