Permalink
Browse files

Run tests in Firefox instead of PhantomJS.

Was hitting some issues (with uncommitted code) with PhantomJS.
zenoamaro/react-quill#87 was making React run console.error, which blows
up PhantomJS.

scala-js/scala-js#1555
ariya/phantomjs#13112

Running tests in Firefox seems more stable, though slower.
Unfortunately, I can't run headless firefox on Mac, which is annoying.
There is no X11 version of firefox available via brew
(Homebrew/legacy-homebrew#9150), or anywhere else apparently
(https://trac.macports.org/ticket/42087)
  • Loading branch information...
gshakhn committed Apr 16, 2016
1 parent 6273506 commit 7a23f660d3eefb1d32013cbb5d32f2bcb8c89abe
Showing with 6 additions and 1 deletion.
  1. +3 −1 .travis.yml
  2. +1 −0 build.sbt
  3. +2 −0 project/plugins.sbt
View
@@ -12,4 +12,6 @@ script:
sudo: false
cache:
directories:
- $HOME/.ivy2
- $HOME/.ivy2
addons:
firefox: latest
View
@@ -38,6 +38,7 @@ val client = project.dependsOn(sharedJS)
jsDependencies += RuntimeDOM % "test",
skip in packageJSDependencies := false,
scalaJSUseRhino in Global := false,
jsEnv in Test := new org.scalajs.jsenv.selenium.SeleniumJSEnv(org.scalajs.jsenv.selenium.Firefox),
jsDependencies ++= Seq(
"org.webjars" % "jquery" % jQueryVersion / s"$jQueryVersion/jquery.js",
"org.webjars" % "bootstrap" % bootstrapVersion / "bootstrap.js" dependsOn s"$jQueryVersion/jquery.js",
View
@@ -1,5 +1,7 @@
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.8")
libraryDependencies += "org.scala-js" %% "scalajs-env-selenium" % "0.1.2"
addSbtPlugin("com.timushev.sbt" % "sbt-updates" % "0.1.10")
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "0.7.0")

0 comments on commit 7a23f66

Please sign in to comment.