Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unique accessor bug #19

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

robrwo
Copy link

@robrwo robrwo commented May 17, 2019

This fixes #18 by looking up the actual column from the accessor name for the search condition used to check uniqueness.

Note that tests still pass with this change.
This causes tests to fail (which is what we want, before we fix
this bug).
This reverts commit e4d66f53b21ce19466769cc067cc9eeaaf34a639.

Note that the tests pass again.
We need the ability to look up original column names from the
accessor names. This allows the information to be cached for
a form.
This fixes gshank#18 by using the column name instead of the accessor
in the search condition.
@robrwo
Copy link
Author

robrwo commented May 29, 2019

@gshank ?

1 similar comment
@robrwo
Copy link
Author

robrwo commented Jun 28, 2019

@gshank ?

@robrwo
Copy link
Author

robrwo commented Jul 2, 2021

It's been over two years since I submitted this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniqueness checks should use actual column names, not accessors
1 participant