Skip to content

Commit

Permalink
Merge pull request rspec#564 from pyromaniac/patch-1
Browse files Browse the repository at this point in the history
Prefer described_class over describes
  • Loading branch information
dchelimsky committed Feb 5, 2012
2 parents 49ea20b + a4c33a5 commit 8a6f77b
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/rspec/core/metadata.rb
Expand Up @@ -102,8 +102,8 @@ module GroupMetadataHash

def described_class
container_stack.each do |g|
return g[:describes] if g.has_key?(:describes)
return g[:described_class] if g.has_key?(:described_class)
return g[:describes] if g.has_key?(:describes)
end

container_stack.reverse.each do |g|
Expand Down
16 changes: 16 additions & 0 deletions spec/rspec/core/example_group_spec.rb
Expand Up @@ -293,6 +293,22 @@ def metadata_hash(*args)
group.run.should be_true
end
end

context "and metadata redefinition after `described_class` call" do
it "is the redefined level constant" do
group = ExampleGroup.describe(String) do
described_class
metadata[:example_group][:described_class] = Object
describe :symbol do
example "described_class is Object" do
described_class.should eq(Object)
end
end
end

group.run.should be_true
end
end
end

context "in a nested group" do
Expand Down

0 comments on commit 8a6f77b

Please sign in to comment.