From fb320182055a1dd680bd04f4aaaf9eb84d0d4041 Mon Sep 17 00:00:00 2001 From: Peixin Li Date: Tue, 3 Jan 2023 18:48:00 -0800 Subject: [PATCH] Fix the message strings for xcodeMissing and xcodeIncomplete (#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test --- packages/flutter_tools/lib/src/base/user_messages.dart | 4 ++-- .../test/general.shard/base/user_messages_test.dart | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/flutter_tools/lib/src/base/user_messages.dart b/packages/flutter_tools/lib/src/base/user_messages.dart index c3f4a69173cf..d8236e3c33e8 100644 --- a/packages/flutter_tools/lib/src/base/user_messages.dart +++ b/packages/flutter_tools/lib/src/base/user_messages.dart @@ -176,10 +176,10 @@ class UserMessages { 'Launch Xcode and install additional required components when prompted or run:\n' ' sudo xcodebuild -runFirstLaunch'; String get xcodeMissing => - 'Xcode not installed; this is necessary for iOS development.\n' + 'Xcode not installed; this is necessary for iOS and macOS development.\n' 'Download at https://developer.apple.com/xcode/download/.'; String get xcodeIncomplete => - 'Xcode installation is incomplete; a full installation is necessary for iOS development.\n' + 'Xcode installation is incomplete; a full installation is necessary for iOS and macOS development.\n' 'Download at: https://developer.apple.com/xcode/download/\n' 'Or install Xcode via the App Store.\n' 'Once installed, run:\n' diff --git a/packages/flutter_tools/test/general.shard/base/user_messages_test.dart b/packages/flutter_tools/test/general.shard/base/user_messages_test.dart index 862fb2a08e0c..a001bbf4b460 100644 --- a/packages/flutter_tools/test/general.shard/base/user_messages_test.dart +++ b/packages/flutter_tools/test/general.shard/base/user_messages_test.dart @@ -30,4 +30,10 @@ void main() { checkInstallationURL((Platform platform) => userMessages.androidSdkBuildToolsOutdated(0, '', platform)); checkInstallationURL((Platform platform) => userMessages.androidStudioInstallation(platform)); }); + + testWithoutContext('Xcode installation instructions', () { + final UserMessages userMessages = UserMessages(); + expect(userMessages.xcodeMissing, contains('iOS and macOS')); + expect(userMessages.xcodeIncomplete, contains('iOS and macOS')); + }); }