Skip to content
Permalink
Browse files Browse the repository at this point in the history
Unlock cond_mutex before pthread exit in gp_worker_main()
Signed-off-by: GuiYao <guiyao@huawei.com>
[rharwood@redhat.com: whitespace, tweak commit message]
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
  • Loading branch information
Guiyao authored and frozencemetery committed Mar 26, 2020
1 parent 23c5215 commit cb76141
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/gp_workers.c
Expand Up @@ -369,6 +369,7 @@ static void *gp_worker_main(void *pvt)
/* wait for next query */
pthread_cond_wait(&t->cond_wakeup, &t->cond_mutex);
if (t->pool->shutdown) {
pthread_mutex_unlock(&t->cond_mutex);
pthread_exit(NULL);
}
}
Expand Down

4 comments on commit cb76141

@abergmann
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CVE-2020-12658 was assigned to this commit.

@simo5
Copy link
Contributor

@simo5 simo5 commented on cb76141 Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abergmann why would this be a CVE ?

@frozencemetery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on an exit path from gssproxy. Stalling at that point isn't even a DoS. I likewise don't see how this could be a CVE.

@frozencemetery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have requested that Mitre reject this CVE assignment.

Please sign in to comment.