From 9395bbeb2be542d7a527239eff5952ca21ab617b Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Wed, 28 Oct 2020 10:35:15 -0400 Subject: [PATCH] Clarify mech_for_saslname implementation note There is nothing to actually fix in this function unless we change how interposing works. Add a note and remove the FIXME. Signed-off-by: Simo Sorce --- src/mechglue/gpp_indicate_mechs.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mechglue/gpp_indicate_mechs.c b/src/mechglue/gpp_indicate_mechs.c index bcfa10582..3b4fbe29d 100644 --- a/src/mechglue/gpp_indicate_mechs.c +++ b/src/mechglue/gpp_indicate_mechs.c @@ -176,6 +176,12 @@ OM_uint32 gssi_inquire_mech_for_saslname(OM_uint32 *minor_status, gss_OID *mech_type) { GSSI_TRACE(); - /* FIXME: How to call into mechglue ? */ + /* NOTE: in general it doesn't make a lot of sense to provide this + * function unless we make it possible to export an entire mechanism + * via interposer functions that is not available in the main library. + * That is because any saslname we can interpose is actually going to + * be properly resolved by the main mechanism, and when later the + * returned mechanism type is used in some call we will properly + * interpose as configured. */ return GSS_S_UNAVAILABLE; }