Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client Credentials Grant flow #83

Closed
wants to merge 8 commits into from

Conversation

@contributorpw
Copy link
Collaborator

contributorpw commented Oct 5, 2017

Issue: #82

Alexander Ivanov added 2 commits Oct 5, 2017
Issue: #82
Alexander Ivanov
Issue: #82
Comment:
@erickoledadevrel

This comment has been minimized.

Copy link
Member

erickoledadevrel commented Oct 11, 2017

FYI, I am looking at this PR, but I think it calls into question some fundamental design choices in the library, so I'm thinking things through.

@contributorpw

This comment has been minimized.

Copy link
Collaborator Author

contributorpw commented Oct 11, 2017

@erickoledadevrel , I think I chose a wrong way. I'd like to re-build it to another variant.

I think It needs to use new properties app_key and app_secret like exchangeJwt.

For an example

 OAuth2.createService('drive')
      .setAppId('...')
      .setAppSecret('...')
@contributorpw

This comment has been minimized.

Copy link
Collaborator Author

contributorpw commented Oct 19, 2017

I've changed the implementation, but left the idea.
There are new methods:

  • setConsumerKey
  • setConsumerSecret
  • setGrantType

setGrantType is necessary for extension grants.

@erickoledadevrel erickoledadevrel force-pushed the gsuitedevs:master branch from a50684f to e98c619 Oct 19, 2017
@erickoledadevrel

This comment has been minimized.

Copy link
Member

erickoledadevrel commented Jul 25, 2018

My apologies for leaving this in limbo for so long. I've adapted your work in #133, where I worked to centralize some of the logic and keep the implementation a bit more generic. Please take a look and let me know what you think. I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.