This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
Remove a few unnecessary try..except blocks #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually equivalent because all we do is re-raise the exception when we catch it.
…uest This is actually equivalent because all we do is re-raise the exception when we catch it.
This is actually equivalent because all we do is re-raise the exception when we catch it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for for making this package, I use it (via Home Assistant) and it's great!
There were a few cases where a
try...exceptblock was used but all that was done in theexceptblock was re-raise the exception.This is functionally equivalent to not having a
try..exceptblock at all, so I removed them since it makes the code quite a bit more readable.I also removed some trailing whitespace in several lines, mainly because my editor complains about it. This is in a separate commit so I'd be happy to toss it if you prefer.