Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few unnecessary try..except blocks #2

Merged
merged 4 commits into from Nov 15, 2019

Conversation

@campbellr
Copy link
Contributor

campbellr commented Oct 23, 2019

First of all, thanks for for making this package, I use it (via Home Assistant) and it's great!

There were a few cases where a try...except block was used but all that was done in the except block was re-raise the exception.

This is functionally equivalent to not having a try..except block at all, so I removed them since it makes the code quite a bit more readable.

I also removed some trailing whitespace in several lines, mainly because my editor complains about it. This is in a separate commit so I'd be happy to toss it if you prefer.

campbellr added 4 commits Oct 23, 2019
This is actually equivalent because all we do is re-raise the exception
when we catch it.
…uest

This is actually equivalent because all we do is re-raise the exception
when we catch it.
This is actually equivalent because all we do is re-raise the exception
when we catch it.
@gtdiehl gtdiehl merged commit 470abef into gtdiehl:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.