Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a lot of things #1

Merged
merged 2 commits into from Nov 11, 2018

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 9, 2018

cc @sdroege @EPashkin (sorry, it's really a lot to go through...)

Once this PR merged, I'll move the repository into gtk-rs.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 10, 2018

error[E0599]: no method named `to_glib_none` found for type `&[&auto::text_range::TextRange]` in the current scope
  --> src\auto\text.rs:39:46
   |
39 |             ffi::atk_text_free_ranges(ranges.to_glib_none().0);
   |                                              ^^^^^^^^^^^^
   |
   = note: the method `to_glib_none` exists but the following trait bounds were not satisfied:
           `[&auto::text_range::TextRange] : glib::translate::ToGlibPtr<_>`
           `&[&auto::text_range::TextRange] : glib::translate::ToGlibPtr<_>`
           `[&auto::text_range::TextRange] : glib::translate::ToGlibPtr<_>`
use glib::translate::*;
use glib_ffi;
use std::mem;
use std::ptr;

This comment has been minimized.

@EPashkin

EPashkin Nov 10, 2018

Member

Empty file

Gir.toml Outdated
"Atk.Table",
"Atk.StateType",
"Atk.StateSet",
"Atk.StreamableContent",
"Atk.TableCell",
"Atk.Text",

This comment has been minimized.

@EPashkin

EPashkin Nov 10, 2018

Member

"Atk.Text" this need be removed, as it in separate section

This comment has been minimized.

@EPashkin

EPashkin Nov 10, 2018

Member

After remove and regen free_ranges problem "fixed"

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Nov 10, 2018

Author Member

Forgot to regen before pushing, my bad...

]

ignore = [
"Atk.Relation",
"Atk.Plug", # conflicting implementations of trait `glib::IsA<glib::Object>` for type `auto::plug::Plug`
"Atk.Window", # conflicting implementations of trait `glib::translate::ToGlibPtr<'_, *mut gobject_ffi::GObject>` for type `auto::window::Window`

This comment has been minimized.

@EPashkin

EPashkin Nov 10, 2018

Member

IMHO "Atk.Plug" and "Atk.Window"'s traits need renaming to remove mixing with gdk's and gtk's

This comment has been minimized.

@EPashkin

EPashkin Nov 10, 2018

Member

Hm, there too many trait duplicates with gtk, now I don't sure that it need renaming.

use glib::translate::*;
use glib_ffi;
use std::mem;
use std::ptr;

This comment has been minimized.

@EPashkin

EPashkin Nov 10, 2018

Member

Empty file, not regenerated.
4 others too, so need regen after emptying src\auto

Gir.toml Outdated
"Atk.Layer",
"Atk.Misc",
# "Atk.NoOpObject",

This comment has been minimized.

@EPashkin

EPashkin Nov 10, 2018

Member

IMHO better uncomment this

"Atk.ObjectFactory",
"Atk.Plug",
"Atk.PropertyChangeHandler",
# "Atk.PropertyValues",
"Atk.Range",
"Atk.Rectangle",

This comment has been minimized.

@EPashkin

EPashkin Nov 10, 2018

Member

"Atk.Rectangle" - Boxed type without methods

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Nov 10, 2018

Updated.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 10, 2018

There still empty src/auto/implementor.rs and src/auto/property_values.rs.
Other that that all looks good.

@GuillaumeGomez GuillaumeGomez force-pushed the generate-lot branch from 47e50a7 to ab5bc55 Nov 10, 2018

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Nov 10, 2018

Removed the empty files for good this time.

@GuillaumeGomez GuillaumeGomez merged commit 2b0ed9e into master Nov 11, 2018

@GuillaumeGomez GuillaumeGomez deleted the generate-lot branch Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.