New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement wrappers for win32 surfaces #100

Merged
merged 2 commits into from Jan 24, 2017

Conversation

Projects
None yet
3 participants
@evmar

evmar commented Jan 23, 2017

These changes implement enough win32 surfaces for me to succeed at porting a small program of mine to Windows.

Some things I'm not sure about:

  • do I bump the version number in cairo-sys-rs?
  • I mostly just followed ImageSurface, is that the right thing to do?
Show outdated Hide outdated src/lib.rs Outdated
Show outdated Hide outdated src/win32_surface.rs Outdated
Show outdated Hide outdated cairo-sys-rs/src/lib.rs Outdated
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 23, 2017

Member

Seems globally good to me, thanks!

What about you @EPashkin?

Member

GuillaumeGomez commented Jan 23, 2017

Seems globally good to me, thanks!

What about you @EPashkin?

@@ -37,3 +37,6 @@ version = "0.1.1"
[dependencies]
libc = "0.2"
c_vec = "~1.2"
[target.'cfg(windows)'.dependencies]
winapi = "0.2.7"

This comment has been minimized.

@EPashkin

EPashkin Jan 23, 2017

Member

Empty line at end, please.

@EPashkin

EPashkin Jan 23, 2017

Member

Empty line at end, please.

This comment has been minimized.

@evmar

evmar Jan 24, 2017

Done, here and in the other file.

@evmar

evmar Jan 24, 2017

Done, here and in the other file.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 23, 2017

Member

Looks good

Member

EPashkin commented Jan 23, 2017

Looks good

@evmar

This comment has been minimized.

Show comment
Hide comment
@evmar

evmar Jan 24, 2017

OK, I rebased and cleaned up, take another look.

I also still am not sure if I should change version numbers.

evmar commented Jan 24, 2017

OK, I rebased and cleaned up, take another look.

I also still am not sure if I should change version numbers.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 24, 2017

Member

@evmar: No you're not. Thanks a lot for your work!

Member

GuillaumeGomez commented Jan 24, 2017

@evmar: No you're not. Thanks a lot for your work!

@GuillaumeGomez GuillaumeGomez merged commit 172efa4 into gtk-rs:master Jan 24, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@evmar evmar deleted the evmar:windows branch Jul 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment