New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xcb functions #102

Merged
merged 1 commit into from Jan 30, 2017

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Jan 26, 2017

Fixes #101.

Do you mind giving it a try @Yamakaky please?

Show outdated Hide outdated cairo-sys-rs/src/lib.rs
@@ -55,6 +55,27 @@ pub struct cairo_antialias_t(c_void);
pub struct cairo_line_join_t(c_void);
#[repr(C)]
pub struct cairo_line_cap_t(c_void);
#[cfg(feature = "xlib")]

This comment has been minimized.

@Yamakaky

Yamakaky Jan 27, 2017

Contributor

shouldn't it be xcb?

@Yamakaky

Yamakaky Jan 27, 2017

Contributor

shouldn't it be xcb?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jan 27, 2017

Member

Yes indeed, thanks!

@GuillaumeGomez

GuillaumeGomez Jan 27, 2017

Member

Yes indeed, thanks!

@Yamakaky

This comment has been minimized.

Show comment
Hide comment
@Yamakaky

Yamakaky Jan 27, 2017

Contributor

Did you forget to add xcb_window_t? Also, do you know how I can get a xcb_visualtype_t with only a xcb_connection_t and a xcb_window_t?
The corresponding Xlib code is here (please comment if I did something wrong): https://github.com/Yamakaky/cendre/blob/master/src/surface/xlib.rs#L28-L33

Contributor

Yamakaky commented Jan 27, 2017

Did you forget to add xcb_window_t? Also, do you know how I can get a xcb_visualtype_t with only a xcb_connection_t and a xcb_window_t?
The corresponding Xlib code is here (please comment if I did something wrong): https://github.com/Yamakaky/cendre/blob/master/src/surface/xlib.rs#L28-L33

Show outdated Hide outdated src/context.rs
@@ -88,25 +90,44 @@ impl Context {
self.status().ensure_valid();
}
/// Creates a new Context with all graphics state parameters set to default values

This comment has been minimized.

@EPashkin

EPashkin Jan 27, 2017

Member

@GuillaumeGomez, Cairo docs not under GPL?

@EPashkin

EPashkin Jan 27, 2017

Member

@GuillaumeGomez, Cairo docs not under GPL?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jan 27, 2017

Member

Oh damn, didn't pay attention that docs were regenerated!

@GuillaumeGomez

GuillaumeGomez Jan 27, 2017

Member

Oh damn, didn't pay attention that docs were regenerated!

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 27, 2017

Member

Did you forget to add xcb_window_t? Also, do you know how I can get a xcb_visualtype_t with only a xcb_connection_t and a xcb_window_t?
The corresponding Xlib code is here (please comment if I did something wrong): https://github.com/Yamakaky/cendre/blob/master/src/surface/xlib.rs#L28-L33

I don't know either, that's why I made the inner types public. You can create them yourself from the xlib I suppose.

Member

GuillaumeGomez commented Jan 27, 2017

Did you forget to add xcb_window_t? Also, do you know how I can get a xcb_visualtype_t with only a xcb_connection_t and a xcb_window_t?
The corresponding Xlib code is here (please comment if I did something wrong): https://github.com/Yamakaky/cendre/blob/master/src/surface/xlib.rs#L28-L33

I don't know either, that's why I made the inner types public. You can create them yourself from the xlib I suppose.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 27, 2017

Member

So, removed the unwanted docs and added missing files. Sorry about that!

Member

GuillaumeGomez commented Jan 27, 2017

So, removed the unwanted docs and added missing files. Sorry about that!

@Yamakaky

This comment has been minimized.

Show comment
Hide comment
@Yamakaky

Yamakaky Jan 27, 2017

Contributor

SGTM, otherwise.

Contributor

Yamakaky commented Jan 27, 2017

SGTM, otherwise.

@Yamakaky

This comment has been minimized.

Show comment
Hide comment
@Yamakaky

Yamakaky Jan 30, 2017

Contributor

When do you want to merge this?
Also there are still some functions missing, like Quartz. https://www.cairographics.org/manual/cairo-surfaces.html

Contributor

Yamakaky commented Jan 30, 2017

When do you want to merge this?
Also there are still some functions missing, like Quartz. https://www.cairographics.org/manual/cairo-surfaces.html

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 30, 2017

Member

When you confirm it works for you I guess? We don't have much interest in it so you're the one to tell us in here. ;)

Member

GuillaumeGomez commented Jan 30, 2017

When you confirm it works for you I guess? We don't have much interest in it so you're the one to tell us in here. ;)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 30, 2017

Member

Oh and could you open an issue for the other one as well please?

Member

GuillaumeGomez commented Jan 30, 2017

Oh and could you open an issue for the other one as well please?

@Yamakaky

This comment has been minimized.

Show comment
Hide comment
@Yamakaky

Yamakaky Jan 30, 2017

Contributor

Since I couldn't find how to get an xcb_visualtype_t and XLib works, I didn't check. As it's only function signatures, it should be fine though.

Contributor

Yamakaky commented Jan 30, 2017

Since I couldn't find how to get an xcb_visualtype_t and XLib works, I didn't check. As it's only function signatures, it should be fine though.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 30, 2017

Member

Fine then, let's merge!

Member

GuillaumeGomez commented Jan 30, 2017

Fine then, let's merge!

@GuillaumeGomez GuillaumeGomez merged commit 753d875 into gtk-rs:master Jan 30, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:xcb branch Jan 30, 2017

@EPashkin EPashkin referenced this pull request Mar 4, 2017

Closed

Make a new release #451

@charlesvdv charlesvdv referenced this pull request May 13, 2017

Merged

fix xcb features #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment