New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong feature name #110

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
2 participants
@Yamakaky
Contributor

Yamakaky commented Mar 9, 2017

It's a blocking bug for me, since the code doesn't compile without this fix.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 9, 2017

Member

Oups indeed! Thanks for the fix!

Member

GuillaumeGomez commented Mar 9, 2017

Oups indeed! Thanks for the fix!

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 9, 2017

Member

PS: Waiting for CIs anyway.

Member

GuillaumeGomez commented Mar 9, 2017

PS: Waiting for CIs anyway.

@Yamakaky

This comment has been minimized.

Show comment
Hide comment
@Yamakaky

Yamakaky Mar 9, 2017

Contributor

Could you do a release after that?

Contributor

Yamakaky commented Mar 9, 2017

Could you do a release after that?

@Yamakaky

This comment has been minimized.

Show comment
Hide comment
@Yamakaky

Yamakaky Mar 9, 2017

Contributor

Seems good!

Contributor

Yamakaky commented Mar 9, 2017

Seems good!

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 9, 2017

Member

Euh... For just one commit no, sorry.

Member

GuillaumeGomez commented Mar 9, 2017

Euh... For just one commit no, sorry.

@GuillaumeGomez GuillaumeGomez merged commit 3a7e247 into gtk-rs:master Mar 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Yamakaky Yamakaky deleted the Yamakaky:patch-1 branch Mar 9, 2017

@Yamakaky

This comment has been minimized.

Show comment
Hide comment
@Yamakaky

Yamakaky Mar 10, 2017

Contributor

Well the code doesn't compile, so I would do it.

Contributor

Yamakaky commented Mar 10, 2017

Well the code doesn't compile, so I would do it.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 10, 2017

Member

The release process is quite heavy. Once the "into" feature is merged though, I think we'll do another release. I think it'll be within a month but I can't guarantee it.

So until then, sorry for the disturbance and thanks again for your path!

Member

GuillaumeGomez commented Mar 10, 2017

The release process is quite heavy. Once the "into" feature is merged though, I think we'll do another release. I think it'll be within a month but I can't guarantee it.

So until then, sorry for the disturbance and thanks again for your path!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment