New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quartz functions #115

Merged
merged 1 commit into from Mar 12, 2017

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Mar 12, 2017

Fixes #114.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 12, 2017

Member

@EPashkin: The build failed locally:

> cargo build
   Compiling c_vec v1.2.0
   Compiling libc v0.2.20
   Compiling cairo-rs v0.1.1 (file:///Users/imperio/rust/cairo)
   Compiling bitflags v0.4.0
   Compiling pkg-config v0.3.9
   Compiling bitflags v0.5.0
   Compiling glib-sys v0.3.2 (https://github.com/gtk-rs/sys#11c911ef)
   Compiling gobject-sys v0.3.2 (https://github.com/gtk-rs/sys#11c911ef)
   Compiling cairo-sys-rs v0.3.2 (file:///Users/imperio/rust/cairo/cairo-sys-rs)
   Compiling glib v0.1.1 (https://github.com/gtk-rs/glib#91f2ceb4)
error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/context.rs:53:6
   |
53 | impl FromGlibPtrNone<*mut ffi::cairo_t> for Context {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrFull` in this scope
  --> src/context.rs:62:6
   |
62 | impl FromGlibPtrFull<*mut ffi::cairo_t> for Context {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/image_surface.rs:96:6
   |
96 | impl FromGlibPtrNone<*mut ffi::cairo_surface_t> for ImageSurface {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrFull` in this scope
   --> src/image_surface.rs:103:6
    |
103 | impl FromGlibPtrFull<*mut ffi::cairo_surface_t> for ImageSurface {
    |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/rectangle.rs:45:6
   |
45 | impl FromGlibPtrNone<*const ffi::cairo_rectangle_int_t> for RectangleInt {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/rectangle.rs:52:6
   |
52 | impl FromGlibPtrNone<*mut ffi::cairo_rectangle_int_t> for RectangleInt {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/surface.rs:53:6
   |
53 | impl FromGlibPtrNone<*mut ffi::cairo_surface_t> for Surface {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrFull` in this scope
  --> src/surface.rs:62:6
   |
62 | impl FromGlibPtrFull<*mut ffi::cairo_surface_t> for Surface {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error: cannot continue compilation due to previous error

error: Could not compile `cairo-rs`.

Any idea?

Member

GuillaumeGomez commented Mar 12, 2017

@EPashkin: The build failed locally:

> cargo build
   Compiling c_vec v1.2.0
   Compiling libc v0.2.20
   Compiling cairo-rs v0.1.1 (file:///Users/imperio/rust/cairo)
   Compiling bitflags v0.4.0
   Compiling pkg-config v0.3.9
   Compiling bitflags v0.5.0
   Compiling glib-sys v0.3.2 (https://github.com/gtk-rs/sys#11c911ef)
   Compiling gobject-sys v0.3.2 (https://github.com/gtk-rs/sys#11c911ef)
   Compiling cairo-sys-rs v0.3.2 (file:///Users/imperio/rust/cairo/cairo-sys-rs)
   Compiling glib v0.1.1 (https://github.com/gtk-rs/glib#91f2ceb4)
error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/context.rs:53:6
   |
53 | impl FromGlibPtrNone<*mut ffi::cairo_t> for Context {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrFull` in this scope
  --> src/context.rs:62:6
   |
62 | impl FromGlibPtrFull<*mut ffi::cairo_t> for Context {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/image_surface.rs:96:6
   |
96 | impl FromGlibPtrNone<*mut ffi::cairo_surface_t> for ImageSurface {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrFull` in this scope
   --> src/image_surface.rs:103:6
    |
103 | impl FromGlibPtrFull<*mut ffi::cairo_surface_t> for ImageSurface {
    |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/rectangle.rs:45:6
   |
45 | impl FromGlibPtrNone<*const ffi::cairo_rectangle_int_t> for RectangleInt {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/rectangle.rs:52:6
   |
52 | impl FromGlibPtrNone<*mut ffi::cairo_rectangle_int_t> for RectangleInt {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrNone` in this scope
  --> src/surface.rs:53:6
   |
53 | impl FromGlibPtrNone<*mut ffi::cairo_surface_t> for Surface {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error[E0405]: cannot find trait `FromGlibPtrFull` in this scope
  --> src/surface.rs:62:6
   |
62 | impl FromGlibPtrFull<*mut ffi::cairo_surface_t> for Surface {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ did you mean `FromGlibPtr`?

error: cannot continue compilation due to previous error

error: Could not compile `cairo-rs`.

Any idea?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin
Member

EPashkin commented Mar 12, 2017

https://github.com/gtk-rs/glib#91f2ceb4 is too old
delete lock?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 12, 2017

Member

Ok, passed locally. However, there is a strange failure on nightly...

Member

GuillaumeGomez commented Mar 12, 2017

Ok, passed locally. However, there is a strange failure on nightly...

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 12, 2017

Member

Cargo failure issue rust-lang/cargo#3819

Member

EPashkin commented Mar 12, 2017

Cargo failure issue rust-lang/cargo#3819

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 12, 2017

Member

Cargo once again...

Member

GuillaumeGomez commented Mar 12, 2017

Cargo once again...

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 12, 2017

Member

@EPashkin: Does the code seem ok to you by the way?

Member

GuillaumeGomez commented Mar 12, 2017

@EPashkin: Does the code seem ok to you by the way?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 12, 2017

Member

Yes, code seems right.
About cargo: interesting comment rust-lang/cargo#3819 (comment) Maybe these failures don't repeated after check fixed.

Member

EPashkin commented Mar 12, 2017

Yes, code seems right.
About cargo: interesting comment rust-lang/cargo#3819 (comment) Maybe these failures don't repeated after check fixed.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 12, 2017

Member

Should I merge then?

Member

GuillaumeGomez commented Mar 12, 2017

Should I merge then?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 12, 2017

Member

IMHO yes

Member

EPashkin commented Mar 12, 2017

IMHO yes

@GuillaumeGomez GuillaumeGomez merged commit e5bf5d8 into gtk-rs:master Mar 12, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:quartz branch Mar 12, 2017

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 12, 2017

Member

Thanks for the review! ;)

Member

GuillaumeGomez commented Mar 12, 2017

Thanks for the review! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment