New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MatrixTrait::try_invert() #117

Merged
merged 2 commits into from Jul 6, 2017

Conversation

Projects
None yet
3 participants
@federicomenaquintero
Contributor

federicomenaquintero commented Mar 16, 2017

As discussed in #116

I also added PartialEq to Matrix, so I can compare it in tests :)

Show outdated Hide outdated src/matrices.rs Outdated
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 16, 2017

Member

Excellent, thanks a lot! I'm strongly in favor of this PR.

Is it ok for you as well @EPashkin?

Member

GuillaumeGomez commented Mar 16, 2017

Excellent, thanks a lot! I'm strongly in favor of this PR.

Is it ok for you as well @EPashkin?

@federicomenaquintero

This comment has been minimized.

Show comment
Hide comment
@federicomenaquintero

federicomenaquintero Mar 16, 2017

Contributor

Squashed the missing comma, and added docs for invert() as well.

Contributor

federicomenaquintero commented Mar 16, 2017

Squashed the missing comma, and added docs for invert() as well.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 16, 2017

Member

Thanks a lot! Just waiting for @EPashkin's opinion now.

Member

GuillaumeGomez commented Mar 16, 2017

Thanks a lot! Just waiting for @EPashkin's opinion now.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 17, 2017

Member

@GuillaumeGomez Code looks good.
But Travis failed due presence of docs.
It need moved to https://github.com/gtk-rs/lgpl-docs ?

Member

EPashkin commented Mar 17, 2017

@GuillaumeGomez Code looks good.
But Travis failed due presence of docs.
It need moved to https://github.com/gtk-rs/lgpl-docs ?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 17, 2017

Member

Well, that's the strange part. I think we never had the case.

@federicomenaquintero: Can you move it in the lgpl-docs repo as @EPashkin suggested please?

Member

GuillaumeGomez commented Mar 17, 2017

Well, that's the strange part. I think we never had the case.

@federicomenaquintero: Can you move it in the lgpl-docs repo as @EPashkin suggested please?

@federicomenaquintero

This comment has been minimized.

Show comment
Hide comment
@federicomenaquintero

federicomenaquintero Mar 22, 2017

Contributor

Uh, how do I build the docs from lgpl-docs? :) I'd like to see if I'm writing the right thing there.

Contributor

federicomenaquintero commented Mar 22, 2017

Uh, how do I build the docs from lgpl-docs? :) I'd like to see if I'm writing the right thing there.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 22, 2017

Member

To build docs you need add it from https://github.com/gtk-rs/lgpl-docs with

cargo build --features embed-lgpl-docs

then build generate docs as always:

cargo doc
Member

EPashkin commented Mar 22, 2017

To build docs you need add it from https://github.com/gtk-rs/lgpl-docs with

cargo build --features embed-lgpl-docs

then build generate docs as always:

cargo doc

federicomenaquintero added some commits Mar 16, 2017

Derive PartialEq and Debug for Matrix
This is to be able to use == in tests for matrices, and to ease
debugging of client programs.
MatrixTrait: add a try_invert() function
See #116 - we return a
Result<Matrix, Status> with the result of cairo_matrix_invert().
@federicomenaquintero

This comment has been minimized.

Show comment
Hide comment
@federicomenaquintero

federicomenaquintero Jul 6, 2017

Contributor

I've removed the docs from my cairo branch, and added them to lgpl-docs in gtk-rs/lgpl-docs#27

Contributor

federicomenaquintero commented Jul 6, 2017

I've removed the docs from my cairo branch, and added them to lgpl-docs in gtk-rs/lgpl-docs#27

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin
Member

EPashkin commented Jul 6, 2017

👍
@federicomenaquintero Thanks.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 6, 2017

Member

Thanks!

Member

GuillaumeGomez commented Jul 6, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit ef0c331 into gtk-rs:master Jul 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@federicomenaquintero federicomenaquintero deleted the federicomenaquintero:matrix-try-invert branch Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment