New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairo-sys: fix enum types #125

Merged
merged 1 commit into from Apr 24, 2017

Conversation

Projects
None yet
3 participants
@johncf
Contributor

johncf commented Apr 24, 2017

Fixes #124

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Apr 24, 2017

👍

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 24, 2017

Member

Seems comments about FontExtents and TextExtents can be removed too.

Member

EPashkin commented Apr 24, 2017

Seems comments about FontExtents and TextExtents can be removed too.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 24, 2017

Member

.. in cairo-sys-rs/src/lib.rs line 433, 435

Member

EPashkin commented Apr 24, 2017

.. in cairo-sys-rs/src/lib.rs line 433, 435

@johncf

This comment has been minimized.

Show comment
Hide comment
@johncf

johncf Apr 24, 2017

Contributor

Should I squash any of those commits?

Contributor

johncf commented Apr 24, 2017

Should I squash any of those commits?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 24, 2017

Member

Yes, please, and thanks for fixing.
👍

Member

EPashkin commented Apr 24, 2017

Yes, please, and thanks for fixing.
👍

@johncf

This comment has been minimized.

Show comment
Hide comment
@johncf

johncf Apr 24, 2017

Contributor

It looks like cairo has no Region implementation yet. So I'll remove pub use enums::RegionOverlap from cairo.

Contributor

johncf commented Apr 24, 2017

It looks like cairo has no Region implementation yet. So I'll remove pub use enums::RegionOverlap from cairo.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 24, 2017

Member

CI passed

Member

EPashkin commented Apr 24, 2017

CI passed

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 24, 2017

Member

Thanks!

Member

GuillaumeGomez commented Apr 24, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit fb88daa into gtk-rs:master Apr 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment