New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error trait for errors #140

Merged
merged 2 commits into from Jul 5, 2017

Conversation

Projects
None yet
4 participants
@EPashkin
Member

EPashkin commented Jul 4, 2017

Closes #137

Also removed unused warning for non "macos" system.

cc @GuillaumeGomez, @sdroege , @RazrFalcon

@GuillaumeGomez

Thanks!

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 4, 2017

Member

CI passed and seems good to me. Unless you prefer to wait for someone else's review?

Member

GuillaumeGomez commented Jul 4, 2017

CI passed and seems good to me. Unless you prefer to wait for someone else's review?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 4, 2017

Member

IMHO better at minimum wait for @RazrFalcon.

Member

EPashkin commented Jul 4, 2017

IMHO better at minimum wait for @RazrFalcon.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 4, 2017

Member

Fine by me. :)

Member

GuillaumeGomez commented Jul 4, 2017

Fine by me. :)

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 4, 2017

Member

👍

Member

sdroege commented Jul 4, 2017

👍

@RazrFalcon

This comment has been minimized.

Show comment
Hide comment
@RazrFalcon

RazrFalcon Jul 5, 2017

Contributor

Looks good. Thanks.

Contributor

RazrFalcon commented Jul 5, 2017

Looks good. Thanks.

@GuillaumeGomez GuillaumeGomez merged commit e1ca9ae into gtk-rs:master Jul 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:error branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment