New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded `mut` #160

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Oct 24, 2017

warning: variable does not need to be mutable
  --> D:/eap/rust/0/cairo\src\image_surface_png.rs:36:9
   |
36 |     let mut buffer = slice::from_raw_parts_mut(data, len as usize);
   |         ^^^^^^^^^^
   |
   = note: #[warn(unused_mut)] on by default

@GuillaumeGomez Not sure that it pass CI.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 24, 2017

Member

Strange appveyor failure, no errors but test failed :(

Member

EPashkin commented Oct 24, 2017

Strange appveyor failure, no errors but test failed :(

@EPashkin EPashkin referenced this pull request Oct 24, 2017

Merged

Fix doc build #159

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 27, 2017

Member

I tested building 32bit rust on windows 7 64 show messagebox with this text.

cargo test -v --no-default-features --features "png"
---------------------------
cairo-e53d705d37bebe62.exe - Точка входа не найдена //Entry point not found
---------------------------
Точка входа в процедуру __divmoddi4 не найдена в библиотеке DLL libgcc_s_dw2-1.dll. 
-------------------------

without cargo cairo-e53d705d37bebe62.exe running fine

Member

EPashkin commented Oct 27, 2017

I tested building 32bit rust on windows 7 64 show messagebox with this text.

cargo test -v --no-default-features --features "png"
---------------------------
cairo-e53d705d37bebe62.exe - Точка входа не найдена //Entry point not found
---------------------------
Точка входа в процедуру __divmoddi4 не найдена в библиотеке DLL libgcc_s_dw2-1.dll. 
-------------------------

without cargo cairo-e53d705d37bebe62.exe running fine

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 27, 2017

Member

Ah. A change in DLLs then?

Member

GuillaumeGomez commented Oct 27, 2017

Ah. A change in DLLs then?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 27, 2017

Member

On windows 10 x64 same scenario runs normally.

Member

EPashkin commented Oct 27, 2017

On windows 10 x64 same scenario runs normally.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 27, 2017

Member

Yes, toolchain bin folder (.rustup/stable-i686-pc-windows-gnu/bin) contains libgcc_s_dw2-1.dll from 2017-03-30 without __divmoddi4
while msys32 bin folder - libgcc_s_dw2-1.dll from 2017-08-15 with it.
Don't fully understand why it used on windows7 but not used on my machine,
but if I rename it in toolchain cargo tests fine

Member

EPashkin commented Oct 27, 2017

Yes, toolchain bin folder (.rustup/stable-i686-pc-windows-gnu/bin) contains libgcc_s_dw2-1.dll from 2017-03-30 without __divmoddi4
while msys32 bin folder - libgcc_s_dw2-1.dll from 2017-08-15 with it.
Don't fully understand why it used on windows7 but not used on my machine,
but if I rename it in toolchain cargo tests fine

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 27, 2017

Member

32bit build "fixed" but I don't like this method, so IMHO better wait.

Member

EPashkin commented Oct 27, 2017

32bit build "fixed" but I don't like this method, so IMHO better wait.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 31, 2017

Member

@GuillaumeGomez I still not found better solution, so this ready for merge.

Member

EPashkin commented Oct 31, 2017

@GuillaumeGomez I still not found better solution, so this ready for merge.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 31, 2017

Member

Ok. Thanks then!

Member

GuillaumeGomez commented Oct 31, 2017

Ok. Thanks then!

@GuillaumeGomez GuillaumeGomez merged commit f0fc8e8 into gtk-rs:master Oct 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:remove_warning branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment