New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unions: cairo_pattern_t to u8 #166

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
4 participants
@Luke-Nukem

Luke-Nukem commented Nov 13, 2017

Is required for this PR for unions in gir.

This is a bit of a sticky situation... Proper union support in Rust requires that the unions and everything they contain must implement or derive Copy,Clone, and c_void does not allow this.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 13, 2017

Member

Sounds good to me.

cc @EPashkin @sdroege

Member

GuillaumeGomez commented Nov 13, 2017

Sounds good to me.

cc @EPashkin @sdroege

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Nov 13, 2017

Member

Sure, also derive Debug please

Member

sdroege commented Nov 13, 2017

Sure, also derive Debug please

@Luke-Nukem

This comment has been minimized.

Show comment
Hide comment
@Luke-Nukem

Luke-Nukem commented Nov 13, 2017

@sdroege, done 😃

@Luke-Nukem

This comment has been minimized.

Show comment
Hide comment
@Luke-Nukem

Luke-Nukem Nov 13, 2017

Fixed a hiccup. Looks good to go.

Luke-Nukem commented Nov 13, 2017

Fixed a hiccup. Looks good to go.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 13, 2017

Member

👍 too.

Member

EPashkin commented Nov 13, 2017

👍 too.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 13, 2017

Member

Thanks!

Member

GuillaumeGomez commented Nov 13, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit e51b2e6 into gtk-rs:master Nov 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment