New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: don't restrict c_vec version #173

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
3 participants
@ignatenkobrain
Contributor

ignatenkobrain commented Jan 6, 2018

No description provided.

Igor Gnatenko
@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Jan 6, 2018

Why would we not want to restrict the c_vec version?

@ignatenkobrain

This comment has been minimized.

Contributor

ignatenkobrain commented Jan 6, 2018

@GuillaumeGomez I think question is rather opposite, why would you? c_vec is not known (to my knowledge) by breaking API between minor versions.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Jan 6, 2018

Well, I have to admit that I don't care enough about it to start a debate so let's say it's ok for me. 😆

@EPashkin: Any reason we shouldn't merge this PR? Otherwise I'm just gonna merge.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Jan 6, 2018

IMHO restricting really unneeded, It was done for version 1.0, and just upgraded since.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Jan 6, 2018

Then I merge.

Thanks @ignatenkobrain!

@GuillaumeGomez GuillaumeGomez merged commit 8e694c5 into gtk-rs:master Jan 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ignatenkobrain ignatenkobrain deleted the ignatenkobrain:patch-1 branch Jan 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment