New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove box #184

Merged
merged 2 commits into from Apr 15, 2018

Conversation

Projects
None yet
3 participants
@Brooooooklyn
Contributor

Brooooooklyn commented Apr 13, 2018

A rough fix for #183

Note
This PR introduced some breaking changes

Show outdated Hide outdated src/lib.rs
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 13, 2018

Member

Just one nit but everything else seems good, thanks!

Member

GuillaumeGomez commented Apr 13, 2018

Just one nit but everything else seems good, thanks!

Brooooooklyn added some commits Apr 12, 2018

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 15, 2018

Member

@GuillaumeGomez Travis passed here, cargo test and building examples works for me on Windows with latest cairo

Member

EPashkin commented Apr 15, 2018

@GuillaumeGomez Travis passed here, cargo test and building examples works for me on Windows with latest cairo

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 15, 2018

Member

That's weird... I'm not too happy to merge if the CI is going to fail on every new PR to cairo but if it works for you, then it's fine for me. Can you still take a look at what's going wrong please?

Member

GuillaumeGomez commented Apr 15, 2018

That's weird... I'm not too happy to merge if the CI is going to fail on every new PR to cairo but if it works for you, then it's fine for me. Can you still take a look at what's going wrong please?

@GuillaumeGomez GuillaumeGomez merged commit cd377e6 into gtk-rs:master Apr 15, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 15, 2018

Member

@GuillaumeGomez see #185 problem seems "self-solved", just need wait until apveyor update mingw64 on image.
Or we add update in your script for cairo.

Member

EPashkin commented Apr 15, 2018

@GuillaumeGomez see #185 problem seems "self-solved", just need wait until apveyor update mingw64 on image.
Or we add update in your script for cairo.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 15, 2018

Member

Oh cool! And as you prefer.

Member

GuillaumeGomez commented Apr 15, 2018

Oh cool! And as you prefer.

@Brooooooklyn

This comment has been minimized.

Show comment
Hide comment
@Brooooooklyn

Brooooooklyn Apr 17, 2018

Contributor

@GuillaumeGomez would you please update Cargo version? So I could update my project

Contributor

Brooooooklyn commented Apr 17, 2018

@GuillaumeGomez would you please update Cargo version? So I could update my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment