New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more checks #187

Merged
merged 2 commits into from May 16, 2018

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Apr 22, 2018

No description provided.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 15, 2018

Member

I found the issue here on osx: the method ImageSurface::create_from_png. It fails when leaving the read_func. And that's pretty much all we can get at this point... I suppose there is a bug in the osx implementation. We can still make a workaround for osx.

Member

GuillaumeGomez commented May 15, 2018

I found the issue here on osx: the method ImageSurface::create_from_png. It fails when leaving the read_func. And that's pretty much all we can get at this point... I suppose there is a bug in the osx implementation. We can still make a workaround for osx.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 15, 2018

Member

Apparently not. It just segfaults so unless we fork before catching the signal (which doesn't seem like a very good idea...), we can't prevent it from failing.

Member

GuillaumeGomez commented May 15, 2018

Apparently not. It just segfaults so unless we fork before catching the signal (which doesn't seem like a very good idea...), we can't prevent it from failing.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 16, 2018

Member

It not related to #185?

Member

EPashkin commented May 16, 2018

It not related to #185?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 16, 2018

Member

Ah maybe?

Member

GuillaumeGomez commented May 16, 2018

Ah maybe?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 16, 2018

Member

It seems to be working now so I merge (but the issue on OSX and potentially windows remains).

Member

GuillaumeGomez commented May 16, 2018

It seems to be working now so I merge (but the issue on OSX and potentially windows remains).

@GuillaumeGomez GuillaumeGomez merged commit 8d4e115 into gtk-rs:master May 16, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:ci branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment