New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy warnings #193

Merged
merged 2 commits into from Jun 24, 2018

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Jun 24, 2018

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 24, 2018

Member

MacOs nightly error first appeared in https://travis-ci.org/gtk-rs/cairo/jobs/390374585 for #191
and we think that it futures-related, but seems - not.

Previous PR's job is https://travis-ci.org/gtk-rs/cairo/jobs/380392079 passed.

Member

EPashkin commented Jun 24, 2018

MacOs nightly error first appeared in https://travis-ci.org/gtk-rs/cairo/jobs/390374585 for #191
and we think that it futures-related, but seems - not.

Previous PR's job is https://travis-ci.org/gtk-rs/cairo/jobs/380392079 passed.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 24, 2018

Member

I don't see any between this jobs, maybe just try restart failed?

Member

EPashkin commented Jun 24, 2018

I don't see any between this jobs, maybe just try restart failed?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 24, 2018

Member

It passed now, strange

Member

EPashkin commented Jun 24, 2018

It passed now, strange

pub fn ensure_valid(&self) {
if *self != Status::Success {
panic!("Cairo error {:?}", *self)
pub fn ensure_valid(self) {

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jun 24, 2018

Member

It's supposed to be consumed?

@GuillaumeGomez

GuillaumeGomez Jun 24, 2018

Member

It's supposed to be consumed?

This comment has been minimized.

@EPashkin

EPashkin Jun 24, 2018

Member

Enums is Copy

@EPashkin

EPashkin Jun 24, 2018

Member

Enums is Copy

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jun 24, 2018

Member

Solves issue. :D

@GuillaumeGomez

GuillaumeGomez Jun 24, 2018

Member

Solves issue. :D

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 24, 2018

Member

Thanks!

Member

GuillaumeGomez commented Jun 24, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit aba6ba0 into gtk-rs:master Jun 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:clippy_warnings branch Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment