New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any AsMut<[u8]> + Send + 'static to be used for creating an Ima… #204

Merged
merged 2 commits into from Aug 15, 2018

Conversation

Projects
None yet
2 participants
@sdroege
Member

sdroege commented Aug 15, 2018

…geSurface

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 15, 2018

Member

Examples will need to be updated apparently:

error[E0061]: this function takes 5 parameters but 6 parameters were supplied
Member

GuillaumeGomez commented Aug 15, 2018

Examples will need to be updated apparently:

error[E0061]: this function takes 5 parameters but 6 parameters were supplied
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Aug 15, 2018

Member

Ok, I'll do that once this here is merged. Just a matter of removing that parameter

Member

sdroege commented Aug 15, 2018

Ok, I'll do that once this here is merged. Just a matter of removing that parameter

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 15, 2018

Member

Thanks! Merging this while meanwhile.

Member

GuillaumeGomez commented Aug 15, 2018

Thanks! Merging this while meanwhile.

@GuillaumeGomez GuillaumeGomez merged commit ce80b03 into gtk-rs:master Aug 15, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Aug 15, 2018

Member

Ugh actually not that simple, the code assumes this weird free-function. I refer to gtk-rs/examples#181, that code needs some serious refactoring.

I'll fix it up

Member

sdroege commented Aug 15, 2018

Ugh actually not that simple, the code assumes this weird free-function. I refer to gtk-rs/examples#181, that code needs some serious refactoring.

I'll fix it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment