Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cairo_font_type_t #219

Merged
merged 1 commit into from Nov 25, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Nov 23, 2018

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 23, 2018

Maybe all enums need be exported under cairo names?

@@ -58,6 +58,7 @@ pub type CairoSvgUnit = c_int;
pub type CairoTextClusterFlags = c_int;

pub type cairo_antialias_t = CairoAntialias;
pub type cairo_font_type_t = CairoFontType;

This comment has been minimized.

@sdroege

sdroege Nov 24, 2018

Member

Maybe in -sys we should only have the names as in C, and the CamelCase enum types only in the non-sys crate? That's more consistent with everything else.

This comment has been minimized.

@EPashkin

EPashkin Nov 24, 2018

Author Member

Agree.
@GuillaumeGomez What you think?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Nov 24, 2018

Member

I agree as well.

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 24, 2018

Ok then I do changes here

@EPashkin EPashkin force-pushed the EPashkin:add_cairo_font_type_t branch from dc5c812 to 0e3c447 Nov 24, 2018

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 24, 2018

Updated
Also found that we have two cairo_fill_rule_t 😉

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 25, 2018

Thanks a lot!

@GuillaumeGomez GuillaumeGomez merged commit c8e86f9 into gtk-rs:master Nov 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:add_cairo_font_type_t branch Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.