Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get/set_device_offset methods #230

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@osa1
Copy link
Contributor

osa1 commented Jan 23, 2019

Fixes #229

Show resolved Hide resolved src/image_surface.rs Outdated

@osa1 osa1 force-pushed the osa1:surface_methods branch from fdc7665 to 37c32b0 Jan 23, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 23, 2019

@osa1 Thanks.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 23, 2019

👍

1 similar comment
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 23, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 23, 2019

Would be nice to also add device_scale and fallback_resolution at the same time. Very closely related and otherwise someone else will be sad that it's missing in a few weeks :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 23, 2019

Thanks!

@sdroege: I'll do it.

@GuillaumeGomez GuillaumeGomez merged commit 6f111a7 into gtk-rs:master Jan 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 23, 2019

@sdroege: I'll do it.

You mean you'll add the other ones? Ok :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 23, 2019

I was thinking about going to Mars but that too! 😛

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 23, 2019

What do you want on Mars? There's nothing there ;)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 23, 2019

Because I'm not there yet! 😈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.