Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Surface methods &self from &mut self, remove Send impls #233

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@osa1
Copy link
Contributor

osa1 commented Jan 23, 2019

Fixes #232

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 23, 2019

👍

1 similar comment
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 23, 2019

👍

@osa1 osa1 changed the title Make Surface methods &self from &mut self Make Surface methods &self from &mut self, remove Send impls Jan 23, 2019

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 23, 2019

Still looks good to me :)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 23, 2019

@GuillaumeGomez This of course breaks the example that makes use of the Send impl on the image surface but that example should be rewritten IMHO anyway, it's quite ugly :) I can make it work again without rewriting it all though, once this is merged here.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 23, 2019

Ok, then I'll just merge and wait for your example rewrite. :)

Thanks @osa1 !

@GuillaumeGomez GuillaumeGomez merged commit 7e96a5e into gtk-rs:master Jan 23, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 23, 2019

Ok, then I'll just merge and wait for your example rewrite. :)

Can you create an issue for that and CC me there so I don't forget?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 23, 2019

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.