Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor interface in PDF #234
I did the refactoring on PDF so far as an example (the others are analogous I believe).
I tried my best to reconcile the requirements mentioned in the talk under the commit, let me know if I forgot something.
Basically there's the basic
In the end I decided to leave the
Please see the tests to get a feeling of how the interface is used.
@sdroege Sure, I added and explanation to the commit message, hope it makes sense. Also added the commit removing
this pull request
Jan 25, 2019
@meh I hope I didn't mess up anything for you :) Thank you for looking into this.
@GuillaumeGomez I didn't mean for this to be merged directly, but I guess it's ok if everyone else is ok with it. In any case, I should follow up with equal refacroring in PS & SVG and write docs. I will look into that sometimes in the next couple of days. Thank you as well.