Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis/AppVeyor configuration to test/build more different fea… #237

Merged
merged 4 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Feb 12, 2019

…tures

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

👍

@sdroege sdroege force-pushed the sdroege:travis-xenial2 branch from c6c7b49 to e0b0dc3 Feb 12, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 12, 2019

👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

---- src/pdf.rs - pdf::RefWriter<'w, W>::new (line 261) stdout ----
error[E0433]: failed to resolve: could not find `Stream` in `pdf`
  --> src/pdf.rs:270:20
   |
12 | let surface = pdf::Stream::new(100.0, 100.0, |data|
   |                    ^^^^^^ could not find `Stream` in `pdf`
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

Yeah, the docs stuff here is broken in multiple ways because the CI configuration did not test that. No time to fix that today anymore, maybe tomorrow.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

I'll do it, don't worry.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

Basically there is manual docs in svg.rs (and elsewhere) that will cause stuff to fail now, and there's the doctest stuff that also has to enable the features (e.g. svg for the stuff in svg.rs).

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

@GuillaumeGomez Erm, can you reopen this again and kick travis? :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

Why did it get closed? O.o

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

Because you closed it in your commit message :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

We have some manual docs once again? Let's fix it as well!

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

You add them to lgpl-docs and after that I fix this one here?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

Yep. Creating the PR in a few minutes.

@sdroege sdroege referenced this pull request Feb 12, 2019

Closed

Remove doc comments #238

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

We have broken code in docs it seems

---- src/patterns.rs - patterns::Mesh::new (line 444) stdout ----
error: expected one of `!`, `.`, `::`, `;`, `?`, `{`, `}`, or an operator, found `Side`
 --> src/patterns.rs:445:8
  |
3 | C1     Side 1       C2
  |        ^^^^ expected one of 8 possible tokens here
error[E0425]: cannot find value `C1` in this scope
 --> src/patterns.rs:445:1
  |
3 | C1     Side 1       C2
  | ^^ not found in this scope
thread 'src/patterns.rs - patterns::Mesh::new (line 444)' panicked at 'couldn't compile the test', src/librustdoc/test.rs:354:13
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Requires v1_12 to happen. Which we maybe should make the default. cairo 1.12 is from 2012 (!).

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

Arf!

@GuillaumeGomez GuillaumeGomez referenced this pull request Feb 12, 2019

Merged

fix docs #51

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

Should we make v1_12 the default or what do you think?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

Makes sense to me.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

Ok, done :)

Now while checking, I also noticed that a) we use 1.12 symbols since quite a while unconditionally anyway so nobody is running with < 1.12, and b) we now also use 1.16 (!) symbols unconditionally.

Someone should go through these lists and put things behind correct feature flags:
https://www.cairographics.org/manual/index-1.14.html
https://www.cairographics.org/manual/index-1.16.html (we use the pdf surface functions since the latest PR)

@GuillaumeGomez can you take care of this or should I put it somewhere on my list?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

I'll do it, no worries. I'll still open an issue though!

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 12, 2019

Ok all good. The only failure is an OSX worker that didn't start so we can overlook it. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 8984173 into gtk-rs:master Feb 12, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.