Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types and version features #240

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Feb 12, 2019

Fixes #239.

cc @sdroege @EPashkin

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:missing-types-and-version-features branch from ce07432 to 279b7e6 Feb 12, 2019

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Feb 13, 2019

Looks good to me, but you also added some new functions that we didn't have before and the commit message does not mention that :) You didn't add all new functions though, only some (and there are also many from 1.12 that we are still missing IIRC).

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Feb 13, 2019

I added all 1.14 and 1.16 functions/constants. I can add the 1.12 stuff as well. I'll do it in another PR though. I'll merge this one for the moment.

@GuillaumeGomez GuillaumeGomez merged commit 346fd93 into gtk-rs:master Feb 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:missing-types-and-version-features branch Feb 13, 2019

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Feb 13, 2019

I can add the 1.12 stuff as well. I'll do it in another PR though. I'll merge this one for the moment.

Sure, not urgent. If someone needs it someone will ask for it :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Feb 13, 2019

Too late, already implementing everything missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.