New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to version features instead of autodetection #58

Merged
merged 3 commits into from Feb 13, 2016

Conversation

Projects
None yet
2 participants
@gkoz
Member

gkoz commented Feb 12, 2016

Implement the reinstatement of version features outlined in gtk-rs/gtk#243.

  • Installed library version detection no longer impacts conditional compilation.
  • Each crate defaults to supporting a particular minimal upstream version.
  • Higher (newer) versions need to be enabled via cargo features e.g. --features 3.16, features = ["3.16"].
  • The selected version is checked against pkg-config aborting the build if it's too high.
  • The use of pkg-config can be overridden by setting GTK_LIB_DIR env variable, which translates into -L $GTK_LIB_DIR linker argument. No version checks are done in this case.

[breaking change]

gkoz added some commits Feb 10, 2016

Replace version detection with features
- Installed library version detection no longer impacts conditional
  compilation.
- Each crate defaults to supporting a particular minimal upstream
  version.
- Higher (newer) versions need to be enabled via cargo features e.g.
  `--features 3.16`, `features = ["3.16"]`.
- The selected version is checked against `pkg-config` aborting the
  build if it's too high.
- The use of `pkg-config` can be overridden by setting `GTK_LIB_DIR` env
  variable, which translates into `-L $GTK_LIB_DIR` linker argument. No
version checks are done in this case.

[breaking change]

GuillaumeGomez added a commit that referenced this pull request Feb 13, 2016

Merge pull request #58 from gkoz/version_features
Switch to version features instead of autodetection

@GuillaumeGomez GuillaumeGomez merged commit e5e7d93 into gtk-rs:master Feb 13, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment