New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lgpl-docs features and minor cleanups #66

Merged
merged 5 commits into from Feb 28, 2016

Conversation

Projects
None yet
2 participants
@gkoz
Member

gkoz commented Feb 28, 2016

No description provided.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 28, 2016

Member

I can't merge it. Please update it.

Member

GuillaumeGomez commented Feb 28, 2016

I can't merge it. Please update it.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 28, 2016

Member

Also, can you squash the last commit?

Member

GuillaumeGomez commented Feb 28, 2016

Also, can you squash the last commit?

@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Feb 28, 2016

Member

It feels wrong to do that: they change separate entities; adjusting CI is not a part of adding those features.

Member

gkoz commented Feb 28, 2016

It feels wrong to do that: they change separate entities; adjusting CI is not a part of adding those features.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 28, 2016

Member

From my point of view, it's the same change. The first make the second mandatory.

Member

GuillaumeGomez commented Feb 28, 2016

From my point of view, it's the same change. The first make the second mandatory.

@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Feb 28, 2016

Member

Perhaps the CI commits should be phrased better. They certainly depend on the presence of the features but the point is quite different: preventing accidental checkins of embedded docs and secondarily detecting doctests breakage.

Member

gkoz commented Feb 28, 2016

Perhaps the CI commits should be phrased better. They certainly depend on the presence of the features but the point is quite different: preventing accidental checkins of embedded docs and secondarily detecting doctests breakage.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 28, 2016

Member

I won't bother with you on this detail furthermore. I don't agree on your arguments but let's merge it. Great work! Thanks! :)

Member

GuillaumeGomez commented Feb 28, 2016

I won't bother with you on this detail furthermore. I don't agree on your arguments but let's merge it. Great work! Thanks! :)

GuillaumeGomez added a commit that referenced this pull request Feb 28, 2016

Merge pull request #66 from gkoz/docs
Add lgpl-docs features and minor cleanups

@GuillaumeGomez GuillaumeGomez merged commit 9004741 into gtk-rs:master Feb 28, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment