Implement Gradient trait for RadialGradient #83

Merged
merged 1 commit into from Jul 17, 2016

Projects

None yet

4 participants

@Jayshua
Contributor
Jayshua commented Jul 16, 2016

I could be wrong about this, maybe I'm just missing something. Shouldn't the Gradient trait be implemented for RadialGradient?

@Jayshua Jayshua Implement Gradient trait for RadialGradient
5fe5fb0
@EPashkin
Member

👍

@GuillaumeGomez GuillaumeGomez commented on the diff Jul 16, 2016
src/patterns.rs
@@ -245,6 +245,8 @@ impl RadialGradient {
}
}
+impl Gradient for RadialGradient{}
+
@GuillaumeGomez
GuillaumeGomez Jul 16, 2016 Member

Extra empty new line.

@GuillaumeGomez
Member

Thanks!

@gkoz
Member
gkoz commented Jul 16, 2016

👍

@GuillaumeGomez
Member

So everyone is ok with your change. Just remove the extra empty line, squash the extra commit and we're all good!

@Jayshua
Contributor
Jayshua commented Jul 16, 2016

Not that I have a problem with removing the extra line, but I was trying to match the formatting already there and just under the LinearGradient code. Are you sure it shouldn't be there?

@GuillaumeGomez
Member

Not sure about this...

@gkoz: ?

@gkoz
Member
gkoz commented Jul 17, 2016

I'll support @Jayshua on this because following the apparent style is good and it feels uncool to punish a contributor for someone's peculiar choice of style some years ago ;)

@gkoz gkoz merged commit a4a8e95 into gtk-rs:master Jul 17, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez
Member

@gkoz: I just thought it was a typo. Don't want to punish anyone haha.

@Jayshua: Thanks for the PR and sorry for the delay!

@Jayshua
Contributor
Jayshua commented Jul 17, 2016

No problem, glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment