New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-submitting matrix methods for Pattern and Context #95

Merged
merged 3 commits into from Dec 15, 2016

Conversation

Projects
None yet
3 participants
@federicomenaquintero
Contributor

federicomenaquintero commented Dec 1, 2016

No description provided.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Dec 1, 2016

Member

@federicomenaquintero You don't need recreate Pull request, it updated when your master branch

Member

EPashkin commented Dec 1, 2016

@federicomenaquintero You don't need recreate Pull request, it updated when your master branch

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Dec 1, 2016

Member

If you need restart build, just ask @GuillaumeGomez do it.

Member

EPashkin commented Dec 1, 2016

If you need restart build, just ask @GuillaumeGomez do it.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Dec 15, 2016

Member

So, for me it's all good. Tests can't pass because of cargo issue so it's not a problem. Since @EPashkin didn't have express problem to fix, I guess it's ok for him as well. Then let's merge! Thanks for your contribution! :)

Member

GuillaumeGomez commented Dec 15, 2016

So, for me it's all good. Tests can't pass because of cargo issue so it's not a problem. Since @EPashkin didn't have express problem to fix, I guess it's ok for him as well. Then let's merge! Thanks for your contribution! :)

@GuillaumeGomez GuillaumeGomez merged commit 21a7dc0 into gtk-rs:master Dec 15, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@federicomenaquintero

This comment has been minimized.

Show comment
Hide comment
@federicomenaquintero

federicomenaquintero Dec 16, 2016

Contributor

Great, thank you! I'll switch librsvg over to the official repo of gtk-rs/cairo.

Contributor

federicomenaquintero commented Dec 16, 2016

Great, thank you! I'll switch librsvg over to the official repo of gtk-rs/cairo.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Dec 16, 2016

Member

Great, glad to hear it!

Member

GuillaumeGomez commented Dec 16, 2016

Great, glad to hear it!

gnomesysadmins pushed a commit to GNOME/librsvg that referenced this pull request Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment