Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for dnd in a listbox with a listmodel #245

Open
wants to merge 1 commit into
base: master
from

Conversation

@jsparber
Copy link

commented May 12, 2019

This is an example for implementing a queue or anything where the user
can reader a list via dnd. This includes also some animation for hidding
and showing rows

@jsparber jsparber force-pushed the jsparber:dnd_listmodel branch from c8a0714 to 11f6395 May 12, 2019

@jsparber

This comment has been minimized.

Copy link
Author

commented May 12, 2019

I still need to add more comments

@sdroege

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Nice :) I'll review once the comments are there, let me know!

@sdroege

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

@jsparber What's the status of this? Do you plan to update it? :) Would be nice to get this merged as nothing really is missing here apart from some comments from what I understand?

let index = row.get_index() as u32;
let alloc = row.get_allocation();

let index = if y < alloc.y + alloc.height/2 {

This comment has been minimized.

Copy link
@sdroege

sdroege Jun 19, 2019

Member

I believe you want to run cargo fmt once :)

This comment has been minimized.

Copy link
@sdroege

sdroege Sep 2, 2019

Member

Still seems like a good idea :)

This comment has been minimized.

Copy link
@jsparber

jsparber Sep 2, 2019

Author

apparently rustfmt doesn't fix the spaces, actually it doesn't change the file add all

This comment has been minimized.

Copy link
@sdroege

sdroege Sep 2, 2019

Member

That's curious. Don't worry about that then, I'll take a look once the code is done

w.draw(&g);

//TODO fix positioning
//https://stackoverflow.com/questions/24844489/how-to-use-gdk-device-get-position

This comment has been minimized.

Copy link
@sdroege

sdroege Jun 19, 2019

Member

Might be worth to ask someone who knows GTK well to go through these FIXME/TODO comments :)

This comment has been minimized.

Copy link
@jsparber

jsparber Aug 30, 2019

Author

Those are there because i didn't had time to do it. But are actually not that complicated.

This comment has been minimized.

Copy link
@sdroege

sdroege Sep 2, 2019

Member

Let's wait until that is done before merging then?

@jsparber jsparber force-pushed the jsparber:dnd_listmodel branch from 11f6395 to d72ab86 Aug 30, 2019

Add example for dnd in a listbox with a listmodel
This is an example for implementing a queue or anything where the user
can needs to rorder a list via dnd. This includes also some animation
for hidding and showing rows

@jsparber jsparber force-pushed the jsparber:dnd_listmodel branch from d72ab86 to 2f979d5 Aug 30, 2019

@sdroege

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@jsparber any updates? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.