Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs.rs handling #130

Merged
merged 2 commits into from Sep 7, 2019
Merged

Improve docs.rs handling #130

merged 2 commits into from Sep 7, 2019

Conversation

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Sep 7, 2019

@@ -25,13 +25,13 @@ name = "gdk_pixbuf"
v2_32 = ["gdk-pixbuf-sys/v2_32"]
v2_36 = ["v2_32", "gdk-pixbuf-sys/v2_36"]
v2_36_8 = ["v2_36", "gdk-pixbuf-sys/v2_36_8"]
dox = ["glib/dox", "gdk-pixbuf-sys/dox"]
dox = ["glib/dox", "gdk-pixbuf-sys/dox", "futures"]

This comment has been minimized.

Copy link
@sdroege

sdroege Sep 7, 2019

Member

Maybe combine this with removing of the futures feature here?

This comment has been minimized.

Copy link
@sdroege

sdroege Sep 7, 2019

Member

Oh brainfart. We remove the subclass feature, not the futures feature. Ignore this part :)

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Sep 7, 2019

Author Member

Ignored then. :)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 7, 2019

Your commit message doesn't tell us in any way how this is better :) Otherwise apart from the futures feature this looks good to me.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Sep 7, 2019

By not providing useless features to the docs.rs specific stuff. :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Sep 7, 2019

Also, we do it this way for the futures feature handling in other crates. It seems good to me as is. Do you have something else in mind?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 7, 2019

By not providing useless features to the docs.rs specific stuff. :)

I know that, but someone who reads the commit log or even this PR wouldn't :)

Also, we do it this way for the futures feature handling in other crates. It seems good to me as is. Do you have something else in mind?

Seems fine as is. Once we require 1.39 we can remove the feature and always enable it.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Sep 7, 2019

Seems fine as is. Once we require 1.39 we can remove the feature and always enable it.

If we all agree on supported rust starting 1.39, then we should create another issue for this and link it into the "before next release".

@GuillaumeGomez GuillaumeGomez merged commit 92839e7 into gtk-rs:master Sep 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:docs-rs branch Sep 7, 2019
@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.