New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missed callback_guard #66

Merged
merged 1 commit into from Feb 17, 2018

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Feb 17, 2018

Part of gtk-rs/glib#250

Forgot some manual calls

@GuillaumeGomez

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

Hm, seems all rt.rs need removing

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

Or better leave with assert_initialized_main_thread with #[allow(unused_macros)]?
Currently it sole macro in rt.rs and unused in generated code.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 17, 2018

We should really move all the macros inside a common crate. It'd make such things simpler. Anyway, if they're not used, just remove them.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

Updated.

Moving to common crates IMHO impossible as these macros has different meaning in all your crates.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

Single travis failure again.
@GuillaumeGomez Maybe some timeouts need increase?

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

But no printing for 10min still strange, maybe it some infrastructure problem.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 17, 2018

I think so. Let's merge. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 2aba23c into gtk-rs:master Feb 17, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:remove_callback_guard branch Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment