New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove callback guard #78

Merged
merged 3 commits into from Jun 23, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Jun 23, 2018

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 23, 2018

Member

👍

Member

sdroege commented Jun 23, 2018

👍

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 23, 2018

Member

@EPashkin: What did you change btw (in your last commits changes)?

Member

GuillaumeGomez commented Jun 23, 2018

@EPashkin: What did you change btw (in your last commits changes)?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 23, 2018

Member

Remove rt.rs as macros don't used.
Gir.toml don't have generate_safety_asserts = true so assert_initialized_main_thread don't generated and was added only for always generated callback_guard

Member

EPashkin commented Jun 23, 2018

Remove rt.rs as macros don't used.
Gir.toml don't have generate_safety_asserts = true so assert_initialized_main_thread don't generated and was added only for always generated callback_guard

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 23, 2018

Member

CI passed. Thanks @EPashkin!

Member

GuillaumeGomez commented Jun 23, 2018

CI passed. Thanks @EPashkin!

@GuillaumeGomez GuillaumeGomez merged commit 1ca8845 into gtk-rs:master Jun 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:remove_callback_guard branch Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment