Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong connect_xxx_notify #91

Merged
merged 1 commit into from Sep 30, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Sep 29, 2018

Part of gtk-rs/gir#510

Also strange situation: set call notify https://github.com/GNOME/gdk-pixbuf/blob/master/gdk-pixbuf/gdk-pixbuf.c#L1307, but called only in constructor.

cc @GuillaumeGomez. @sdroege

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 29, 2018

👍

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Sep 29, 2018

@sdroege Please look at this PR

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 30, 2018

👍

@GuillaumeGomez GuillaumeGomez merged commit ae672eb into gtk-rs:master Sep 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:remove_connect_xxx_notify_for_ConstructOnly branch Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.