Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GString support #95

Merged
merged 2 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@philn
Copy link
Contributor

philn commented Dec 16, 2018

No description provided.

@@ -121,7 +120,7 @@ impl Pixbuf {
}
}

pub trait PixbufExt {
pub trait PixbufExt: 'static {

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Dec 16, 2018

Member

Is the 'static normal?

This comment has been minimized.

@sdroege
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 11, 2019

@GuillaumeGomez Please merge :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 11, 2019

Yes sir!

Thanks @philn!

@GuillaumeGomez GuillaumeGomez merged commit 9847e2c into gtk-rs:master Jan 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 11, 2019

@philn are there any other PRs still outstanding?

@philn

This comment has been minimized.

Copy link
Contributor Author

philn commented Jan 11, 2019

Hum yes, I believe there's a few more ;) I'll double-check tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.