New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Rectangle from cairo's #119

Merged
merged 1 commit into from May 15, 2016

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented May 14, 2016

No description provided.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 14, 2016

Member

@gkoz Reexport Rectangle in gtk?

Member

EPashkin commented May 14, 2016

@gkoz Reexport Rectangle in gtk?

@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz May 14, 2016

Member

👍

Member

gkoz commented May 14, 2016

👍

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 14, 2016

Member

In generated code it will be gdk::Rectangle but for users IMHO better reexport it

Member

EPashkin commented May 14, 2016

In generated code it will be gdk::Rectangle but for users IMHO better reexport it

@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz May 14, 2016

Member

Reexporting makes sense.

Member

gkoz commented May 14, 2016

Reexporting makes sense.

@EPashkin EPashkin referenced this pull request May 14, 2016

Merged

Widget::size-allocate #340

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 15, 2016

Member

Ping

Member

EPashkin commented May 15, 2016

Ping

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 15, 2016

Member

Sorry for the delay. Thanks!

Member

GuillaumeGomez commented May 15, 2016

Sorry for the delay. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit d61b5b0 into gtk-rs:master May 15, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:rectangle branch May 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment