New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<&str> on Atom #125

Merged
merged 2 commits into from Jul 7, 2016

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Jul 6, 2016

Fixes #120.

Show outdated Hide outdated src/atom.rs Outdated
@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Jul 6, 2016

Member

Oh and it seems appveyor.yml still needs updating in this repo ;p

Member

gkoz commented Jul 6, 2016

Oh and it seems appveyor.yml still needs updating in this repo ;p

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 6, 2016

Member

@gkoz: You want a commit in the same PR or I create another one?

Member

GuillaumeGomez commented Jul 6, 2016

@gkoz: You want a commit in the same PR or I create another one?

@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Jul 6, 2016

Member

This PR is fine.

Member

gkoz commented Jul 6, 2016

This PR is fine.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Jul 7, 2016

@gkoz: Merge?

@gkoz gkoz merged commit a141255 into gtk-rs:master Jul 7, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Jul 7, 2016

Member

Thanks!

Member

gkoz commented Jul 7, 2016

Thanks!

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:from_atom branch Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment