New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowAttr #127

Merged
merged 2 commits into from Jul 25, 2016

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Jul 23, 2016

Rename Attributes to WindowAttr, implement Default
Fixes #126
Related to gtk-rs/gtk#366

@EPashkin EPashkin changed the title from Window attr to WindowAttr Jul 23, 2016

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Jul 23, 2016

👍

Show outdated Hide outdated src/window.rs
@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Jul 23, 2016

Member

Apparently check_init_asserts is unhappy.

Member

gkoz commented Jul 23, 2016

Apparently check_init_asserts is unhappy.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 24, 2016

Member

Updated

Member

EPashkin commented Jul 24, 2016

Updated

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 24, 2016

Member

Seems good for me. I'll let @gkoz handles the merge. ;)

Member

GuillaumeGomez commented Jul 24, 2016

Seems good for me. I'll let @gkoz handles the merge. ;)

@gkoz gkoz merged commit a6f6a67 into gtk-rs:master Jul 25, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gkoz

This comment has been minimized.

Show comment
Hide comment
@gkoz

gkoz Jul 25, 2016

Member

Thanks!

Member

gkoz commented Jul 25, 2016

Thanks!

@EPashkin EPashkin deleted the EPashkin:window_attr branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment