New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Atom container conversion #150

Merged
merged 1 commit into from Mar 30, 2017

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Mar 30, 2017

Fixed errors found in gtk-rs/examples#119

Removed unneeded FromGlibPtrXXX
Added Atom to usize conversion

@GuillaumeGomez, @Susurrus can you test Atom::value?
For windows it return small numbers like 31 not sure about linux and mac

let atom = gdk::Atom::intern("STRING");
println!("atom:{}", atom.name());
println!("{}", unsafe{atom.value()});
Fixed Atom container conversion
Removed unneeded FromGlibPtrXXX
Added Atom to usize conversion
@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Mar 30, 2017

Contributor

Prints

atom:STRING
31

for me on Linux x64.

Thanks @EPashkin for continuing to dig into this, it looks like this fixes the target_list problem we had too. All that's left for gtk-rs/examples#119 is figuring out how to get the drag-data-received signal to actually be triggered.

Contributor

Susurrus commented Mar 30, 2017

Prints

atom:STRING
31

for me on Linux x64.

Thanks @EPashkin for continuing to dig into this, it looks like this fixes the target_list problem we had too. All that's left for gtk-rs/examples#119 is figuring out how to get the drag-data-received signal to actually be triggered.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 30, 2017

Member

cc @GuillaumeGomez, what you think about this fix?

Member

EPashkin commented Mar 30, 2017

cc @GuillaumeGomez, what you think about this fix?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 30, 2017

Member

Less indirection so I approve!

Member

GuillaumeGomez commented Mar 30, 2017

Less indirection so I approve!

@GuillaumeGomez GuillaumeGomez merged commit f4a929e into gtk-rs:master Mar 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fix_atom_container branch Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment