New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromGlibFull and GValue support to Rectangle #151

Merged
merged 3 commits into from Mar 31, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Mar 31, 2017

Tested on Monitor properties geometry and workarea.
As Monitor has normal getters get_geometry for v3.22 these properties will be ignored,
so I make PR before gtk-rs/gir#328 merged

Also fixed Monitor starting version

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 31, 2017

Member

@GuillaumeGomez, please restart CI for this

Member

EPashkin commented Mar 31, 2017

@GuillaumeGomez, please restart CI for this

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Mar 31, 2017

Done.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 31, 2017

Member

Working and seems good to me. Anything else you want to add before I merge?

Member

GuillaumeGomez commented Mar 31, 2017

Working and seems good to me. Anything else you want to add before I merge?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 31, 2017

Member

It ready for merge

Member

EPashkin commented Mar 31, 2017

It ready for merge

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 31, 2017

Member

Thanks!

Member

GuillaumeGomez commented Mar 31, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 227d7f0 into gtk-rs:master Mar 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:gvalue_for_rectangle branch Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment