Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Update #176

Merged
merged 2 commits into from
Jul 12, 2017
Merged

Update #176

merged 2 commits into from
Jul 12, 2017

Conversation

GuillaumeGomez
Copy link
Member

EPashkin
EPashkin reviewed Jul 12, 2017
View reviewed changes
src/window.rs
@@ -113,6 +113,12 @@ impl Window {
attributes.get_mask() as c_int))
}
}

pub fn create_similar_surface(&self, content: cairo::Content, width: i32, height: i32) -> Option<Surface> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&cairo::Content ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it enum.

@EPashkin
Copy link
Member

Maybe add pango::Layout too

@EPashkin
Copy link
Member

pango::Layout generate only bad defined gdk_pango_layout_get_clip_region, so also not need

@EPashkin
Copy link
Member

From errors:
gdk_window_set_opaque_region need const override.
gdk_cairo_surface_create_from_pixbuf has no impl PixbufExt for Pixbuf

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jul 12, 2017 •
edited
Loading

Both fixed. So I didn't add pango::Layout as asked. Anything else? :)

@EPashkin
Copy link
Member

Lost #[cfg(feature = "v3_10")] for impl SurfaceExt for Surface

@GuillaumeGomez
Copy link
Member Author

The function doesn't require it: https://developer.gnome.org/gdk3/stable/gdk3-Cairo-Interaction.html#gdk-cairo-region-create-from-surface

@EPashkin
Copy link
Member

Then need #[cfg(feature = "v3_10")] need removed from use cairo::Surface; ;)

@GuillaumeGomez
Copy link
Member Author

Oups, done!

@EPashkin
Copy link
Member

LGFM
but you don't against gtk-rs/glib#196, IMHO better merge gtk-rs/glib#196 first and update gir+regen in this PR.

@GuillaumeGomez
Copy link
Member Author

@EPashkin: @sdroege told me he would update so I'll merge this one then wait for him to update.

@EPashkin
Copy link
Member

k

@GuillaumeGomez GuillaumeGomez merged commit 0bacf5e into gtk-rs:master Jul 12, 2017
@GuillaumeGomez GuillaumeGomez deleted the update branch July 12, 2017 21:24
@EPashkin EPashkin mentioned this pull request Jul 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EPashkin EPashkin EPashkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @EPashkin